Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode and General House Keeping #174

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Dark Mode and General House Keeping #174

wants to merge 11 commits into from

Conversation

aeadedoyin
Copy link
Contributor

Update NPM Packages
Remove side thick
Fix header scroll-show DIV
Fix search and scroll UX
Add dark/system Mode
General JS file refactoring

@aeadedoyin aeadedoyin requested review from demilad and Odusanya May 10, 2021 17:28
@fathermerry
Copy link
Contributor

@aeadedoyin Can you resolve conflicts so we review this again?

@aeadedoyin
Copy link
Contributor Author

@fathermerry Conflicts are now resolved.
However there seems to be an issue with the Netlify build.

error: UNSUPPORTED BUILD IMAGE

@fathermerry
Copy link
Contributor

Ah yes. Netlify stopped supporting the build server used https://answers.netlify.com/t/please-read-end-of-support-for-trusty-build-image-everything-you-need-to-know/39004

Fixed and published.

@aeadedoyin
Copy link
Contributor Author

@fathermerry All should be fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demilad demilad Awaiting requested review from demilad

@Odusanya Odusanya Awaiting requested review from Odusanya

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeadedoyin @fathermerry